Always allow admins to edit any interface in PortAdmin #2786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't matter that a port is set to an invalid native VLAN, if the user has admin-level access, they should still be allowed to edit the port and fix the problem.
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 5.8.x #2786 +/- ##
==========================================
+ Coverage 57.00% 57.03% +0.03%
==========================================
Files 567 567
Lines 41277 41280 +3
==========================================
+ Hits 23528 23544 +16
+ Misses 17749 17736 -13 ☔ View full report in Codecov by Sentry. |
hmpf
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the authorization logic for editing interface in PortAdmin. Originally, an interface is only considered "editable" if its native VLAN value is one of the VLANs the logged-in user is allowed to edit. For an admin, this list of VLANs consists of all the VLANs that PortAdmin found to be configured on a switch. However, if a port is configured with an invalid native VLAN value, or, as is supported on platforms like JunOS, no default VLAN value is set at all, PortAdmin was unable to determine that such a port was editable at all.
This change ensures the VLAN verification is outright skipped if the user has admin privileges in NAV. All interfaces will be marked as editable.
Fixes #2477