Fix PoE config not showing up for Cisco if interface is missing POEPort #2781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.8.x #2781 +/- ##
==========================================
- Coverage 57.03% 57.03% -0.01%
==========================================
Files 567 567
Lines 41280 41279 -1
==========================================
- Hits 23544 23543 -1
Misses 17736 17736 ☔ View full report in Codecov by Sentry. |
stveit
force-pushed
the
portadmin/fix-cisco-poe
branch
2 times, most recently
from
7572d30 to
92d67ce
Compare
lunkwill42
approved these changes
Dec 13, 2023
lunkwill42
requested changes
Dec 13, 2023
POEIndexNotFoundError will be raised if POEPorts do not exist for an interface, and this is likely to be the case for an interface that does not support PoE. get_poe_states should set state to None for these interfaces, like it does if PoeNotSupportedError is raised.
interface not having poeport should be considered as the interface not supporting poe
lunkwill42
force-pushed
the
portadmin/fix-cisco-poe
branch
from
e938081 to
33381e1
Compare
lunkwill42
approved these changes
Dec 14, 2023
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During navref, UIA mentioned that the new PoE Status column did not show up for their Cisco equipment.
Turns out this is because
get_poe_statesfails if even a single interface does not have a related POEPort object.This was originally intended functionality, even the cisco PoE tests reflects this behaviour. But I realize that a device not having a relation to a POEPort device simply means it does not support PoE, and in that case it should not crash the entire function. It should instead set the state for that interface to
Noneas specified in the docstring forget_poe_statesThis PR fixes this and updates tests accordingly. It also updates
set_poe_stateto behave similarly when it comes to missing PoE indexesAlso fixes a small issue with tests where the property for certain mock objects were named incorrectly.