Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import sudo function from correct module #2777

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Import sudo function from correct module #2777

merged 1 commit into from
Nov 30, 2023

Conversation

johannaengland
Copy link
Contributor

Closes #2766.

@johannaengland johannaengland self-assigned this Nov 30, 2023
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov Codecov
Copy link

codecov bot commented Nov 30, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e0c73c7) 56.20% compared to head (f0e6614) 56.99%.
Report is 3 commits behind head on 5.8.x.

Additional details and impacted files 
@@            Coverage Diff             @@
##            5.8.x    #2777      +/-   ##
==========================================
+ Coverage   56.20%   56.99%   +0.79%     
==========================================
  Files         567      567              
  Lines       41277    41277              
==========================================
+ Hits        23200    23527     +327     
+ Misses      18077    17750     -327

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johannaengland johannaengland linked an issue Nov 30, 2023 that may be closed by this pull request
[BUG] "Operate as user" #2766
Closed
lunkwill42
lunkwill42 approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With tests! YAY!

Guess something got lost in #2706

@github-actions GitHub Actions
Copy link

Test results

     12 files       12 suites   11m 34s ⏱️
3 298 tests 3 298 ✔️ 0 💤 0 ❌
9 369 runs  9 369 ✔️ 0 💤 0 ❌

Results for commit f0e6614.

@johannaengland johannaengland mentioned this pull request Nov 30, 2023
Open
@johannaengland johannaengland merged commit 173d417 into Uninett:5.8.x Nov 30, 2023
12 checks passed
@johannaengland johannaengland deleted the bugfix/useradmin-sudo branch November 30, 2023 12:17
@johannaengland johannaengland mentioned this pull request Nov 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunkwill42 lunkwill42 lunkwill42 approved these changes

@hmpf hmpf Awaiting requested review from hmpf

Assignees

@johannaengland johannaengland

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] "Operate as user"
2 participants
@johannaengland @lunkwill42