Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not make portadmin readonly if poe error #2774

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Do not make portadmin readonly if poe error #2774

merged 1 commit into from
Nov 30, 2023

Conversation

stveit
Copy link
Contributor

@stveit stveit commented Nov 30, 2023

Fixes #2773

stop poe error from making portadmin unusable, instead disable poe and log error

@stveit stveit force-pushed the fix-portadmin-read-only-if-poe-error branch from 9710af0 to 67d2cbd Compare November 30, 2023 07:33
@stveit stveit self-assigned this Nov 30, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 30, 2023 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (064b661) 56.20% compared to head (2e0c8e9) 56.20%.
Report is 3 commits behind head on master.

Files Patch % Lines
python/nav/web/portadmin/views.py 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2774   +/-   ##
=======================================
  Coverage   56.20%   56.20%           
=======================================
  Files         567      567           
  Lines       41277    41277           
=======================================
  Hits        23200    23200           
  Misses      18077    18077

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 30, 2023 •
edited
Loading

Test results

     12 files       12 suites   11m 44s ⏱️
3 296 tests 3 296 ✔️ 0 💤 0 ❌
9 363 runs  9 363 ✔️ 0 💤 0 ❌

Results for commit 2e0c8e9.

♻️ This comment has been updated with latest results.

@lunkwill42 lunkwill42 self-requested a review November 30, 2023 07:59
lunkwill42
lunkwill42 requested changes Nov 30, 2023
View reviewed changes
Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, but you should rebase this on the 5.8.x branch :)

@stveit
Do not make portadmin readonly if poe error
2e0c8e9 
stop poe error from making portadmin unusable, instead disable
poe and log error
@stveit stveit force-pushed the fix-portadmin-read-only-if-poe-error branch from 67d2cbd to 2e0c8e9 Compare November 30, 2023 08:08
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lunkwill42 lunkwill42 changed the base branch from master to 5.8.x November 30, 2023 08:35
lunkwill42
lunkwill42 approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@lunkwill42 lunkwill42 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! :)

@lunkwill42 lunkwill42 merged commit 79b7f97 into Uninett:5.8.x Nov 30, 2023
10 of 11 checks passed
@lunkwill42 lunkwill42 mentioned this pull request Dec 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunkwill42 lunkwill42 lunkwill42 approved these changes

Assignees

@stveit stveit

Labels
bug portadmin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] PortAdmin stopped working for Cisco equipment
2 participants
@stveit @lunkwill42