-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PoE config for Juniper devices #2666
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2666 +/- ##
==========================================
- Coverage 55.19% 55.14% -0.05%
==========================================
Files 561 561
Lines 40917 40983 +66
==========================================
+ Hits 22584 22602 +18
- Misses 18333 18381 +48
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
python/nav/portadmin/napalm/templates/portadmin/junos-enable-poe.djt
Outdated
Show resolved
Hide resolved
af993f9
to
9638692
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't really have much to pick on here, except for the obvious duplicates of #2635 (moving around of test fixtures, and adding new exception classes)
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me. Looking forward to testing against actual equipment :)
Fixes #2633
Adds backend for getting current state for juniper interfaces and changing the state
I will add more /better tests
also the code smells will be fixed..