Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop making validation tests for non HTML content #2623

Merged
merged 2 commits into from
Jun 5, 2023
Merged

Stop making validation tests for non HTML content #2623

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77d6978
Stop making validation tests for non HTML content
lunkwill42 May 24, 2023
40ed7e3
Refactor HTML page filtering
lunkwill42 May 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion tests/integration/web/crawler_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,16 @@ def crawl(self):
if page:
yield page

def crawl_only_html(self):
"""Only yields crawled pages that have a content-type of html and is not
blacklisted.
"""
for page in self.crawl():
if not page.content_type or 'html' not in page.content_type.lower():
continue
if should_validate(page.url):
yield page

def _visit_with_error_handling(self, url):
try:
page = self._visit(url)
Expand Down Expand Up @@ -256,7 +266,7 @@ def _content_as_string(content):
"(ADMINUSERNAME, ADMINPASSWORD) , skipping crawler "
"tests!",
)
@pytest.mark.parametrize("page", crawler.crawl(), ids=page_id)
@pytest.mark.parametrize("page", crawler.crawl_only_html(), ids=page_id)
def test_page_should_be_valid_html(page):
if page.response != 200:
pytest.skip("not validating non-reachable page")
Expand Down