Add unit tests for ipdevpoll worker euthanization #2599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicit coverage of the worker ping and euthanization methods did not exist. Instead, these methods would "accidentally" receive coverage in some test runs, and not at all in others. This would cause coverage stats to flip back and forth, and codecov.io would fail seemingly random PRs for decreasing coverage of these methods. Fixes Uninett#2548
Codecov Report
@@ Coverage Diff @@
## master #2599 +/- ##
==========================================
+ Coverage 54.18% 54.19% +0.01%
==========================================
Files 558 558
Lines 40627 40627
==========================================
+ Hits 22014 22019 +5
+ Misses 18613 18608 -5 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Kudos, SonarCloud Quality Gate passed!
|
johannaengland
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicit coverage of the worker ping and euthanization methods did not exist. Instead, these methods would "accidentally" receive coverage in some test runs, and not at all in others. This would cause coverage stats to flip back and forth, and codecov.io would fail seemingly random PRs for decreasing coverage of these methods.
Fixes #2548