Handle device*Upgrade events with empty variables without crashing #2560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #2560 +/- ##
==========================================
+ Coverage 53.51% 53.54% +0.03%
==========================================
Files 556 556
Lines 40432 40432
==========================================
+ Hits 21638 21651 +13
+ Misses 18794 18781 -13
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lunkwill42
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that after merging #2413 when a device is new and the inventory is first run there is an error since it tries to post an
AlertHistoryVariableentry with the valuenull, which is not allowed. This PR fixes that by changing the old and new version toN/Aif it is null.