Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add related names to django models (images, logger, msgmaint) #2541

Merged
merged 5 commits into from
Jan 10, 2023

Conversation

johannaengland
Copy link
Contributor

This is the third part of splitting up #2423.

@johannaengland johannaengland self-assigned this Jan 5, 2023
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

Test results

     12 files       12 suites   11m 32s ⏱️
3 184 tests 3 088 ✔️   96 💤 0
9 027 runs  8 739 ✔️ 288 💤 0

Results for commit 0aa942e.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #2541 (0aa942e) into master (58e7412) will increase coverage by 0.03%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##           master    #2541      +/-   ##
==========================================
+ Coverage   53.36%   53.39%   +0.03%     
==========================================
  Files         555      555              
  Lines       40361    40361              
==========================================
+ Hits        21539    21552      +13     
+ Misses      18822    18809      -13     
Impacted Files Coverage Δ
python/nav/models/images.py 77.08% <ø> (ø)
python/nav/models/msgmaint.py 79.54% <0.00%> (ø)
python/nav/web/info/images/utils.py 40.00% <0.00%> (ø)
python/nav/web/info/location/views.py 40.00% <ø> (ø)
python/nav/web/info/room/views.py 30.45% <0.00%> (ø)
python/nav/web/maintenance/views.py 23.65% <0.00%> (ø)
python/nav/models/logger.py 93.10% <100.00%> (ø)
python/nav/ipdevpoll/pool.py 89.92% <0.00%> (+5.03%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable :-)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johannaengland johannaengland merged commit 305613c into Uninett:master Jan 10, 2023
@johannaengland johannaengland deleted the related-names-3 branch January 10, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants