Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add related names to django models (api, arnold) #2539

Merged
merged 5 commits into from
Jan 11, 2023
Merged

Add related names to django models (api, arnold) #2539

merged 5 commits into from
Jan 11, 2023

Conversation

johannaengland
Copy link
Contributor

This is the first part of splitting up #2423.

@johannaengland johannaengland self-assigned this Jan 5, 2023
@codecov
Copy link

codecov bot commented Jan 5, 2023 •
edited
Loading

Codecov Report

Merging #2539 (3f78b99) into master (bdd562b) will not change coverage.
The diff coverage is 40.00%.

@@           Coverage Diff           @@
##           master    #2539   +/-   ##
=======================================
  Coverage   53.42%   53.42%           
=======================================
  Files         555      555           
  Lines       40382    40382           
=======================================
  Hits        21573    21573           
  Misses      18809    18809
Impacted Files Coverage Δ
python/nav/models/arnold.py 91.20% <ø> (ø)
python/nav/web/arnold/views.py 21.39% <0.00%> (ø)
python/nav/web/portadmin/utils.py 39.44% <0.00%> (ø)
python/nav/models/api.py 96.42% <100.00%> (ø)
python/nav/web/ipdevinfo/views.py 40.88% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Jan 5, 2023 •
edited
Loading

Test results

     12 files       12 suites   11m 36s ⏱️
3 186 tests 3 090 ✔️   96 💤 0 ❌
9 033 runs  8 745 ✔️ 288 💤 0 ❌

Results for commit 3f78b99.

♻️ This comment has been updated with latest results.

lunkwill42
lunkwill42 requested changes Jan 10, 2023
View reviewed changes
Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but the identity moniker is a bit vague outside the Arnold namespace. I suggest changing it slightly.

python/nav/models/arnold.py Outdated Show resolved Hide resolved
python/nav/models/arnold.py Outdated Show resolved Hide resolved
lunkwill42
lunkwill42 reviewed Jan 11, 2023
View reviewed changes
Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lunkwill42
lunkwill42 approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johannaengland johannaengland merged commit 9e16ace into Uninett:master Jan 11, 2023
@johannaengland johannaengland deleted the related-names-1 branch January 11, 2023 11:42
@johannaengland johannaengland mentioned this pull request Mar 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunkwill42 lunkwill42 lunkwill42 approved these changes

@hmpf hmpf Awaiting requested review from hmpf

@stveit stveit Awaiting requested review from stveit

Assignees

@johannaengland johannaengland

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johannaengland @lunkwill42