Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Graphite queries and error handling in availability stats for device groups #2434

Merged
merged 4 commits into from
Nov 3, 2022

Conversation

johannaengland
Copy link
Contributor

Closes #2345

@johannaengland johannaengland self-assigned this Jun 27, 2022
@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #2434 (56a9cc1) into master (524aac8) will decrease coverage by 0.03%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #2434      +/-   ##
==========================================
- Coverage   52.73%   52.70%   -0.04%     
==========================================
  Files         553      553              
  Lines       40201    40215      +14     
==========================================
- Hits        21202    21196       -6     
- Misses      18999    19019      +20     
Impacted Files Coverage Δ
python/nav/web/info/room/views.py 30.45% <0.00%> (-0.28%) ⬇️
python/nav/web/info/netboxgroup/views.py 28.81% <14.28%> (-1.38%) ⬇️
python/nav/metrics/data.py 55.65% <62.50%> (+0.60%) ⬆️
python/nav/ipdevpoll/pool.py 84.88% <0.00%> (-5.04%) ⬇️
python/nav/util.py 77.58% <0.00%> (+0.86%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@github-actions
Copy link

github-actions bot commented Jun 27, 2022

Test results

     12 files       12 suites   11m 25s ⏱️
3 088 tests 2 992 ✔️   96 💤 0
8 739 runs  8 451 ✔️ 288 💤 0

Results for commit 56a9cc1.

♻️ This comment has been updated with latest results.

@johannaengland johannaengland force-pushed the bugs/devicegroup-crash branch from 87f856c to 4ba54c2 Compare July 1, 2022 09:36
@lunkwill42 lunkwill42 changed the title [BUG] Search for Devicegroup with many members crashes Fix Graphite queries and error handling in availability stats for device groups Jul 7, 2022
Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The graphite error reporting is beautifully done, but there are some issues we should discuss/research when it comes to the chunking parts.

python/nav/metrics/data.py Outdated Show resolved Hide resolved
python/nav/metrics/data.py Outdated Show resolved Hide resolved
python/nav/metrics/data.py Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lunkwill42 lunkwill42 removed request for hmpf and stveit November 3, 2022 11:33
@lunkwill42 lunkwill42 added this to the 5.5.0 milestone Nov 3, 2022
@lunkwill42 lunkwill42 merged commit 0eb76cd into Uninett:master Nov 3, 2022
@johannaengland johannaengland deleted the bugs/devicegroup-crash branch November 24, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Search for Devicegroup with many members crashes
2 participants