-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Graphite queries and error handling in availability stats for device groups #2434
Fix Graphite queries and error handling in availability stats for device groups #2434
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2434 +/- ##
==========================================
- Coverage 52.73% 52.70% -0.04%
==========================================
Files 553 553
Lines 40201 40215 +14
==========================================
- Hits 21202 21196 -6
- Misses 18999 19019 +20
Help us with your feedback. Take ten seconds to tell us how you rate us. |
Instead of erroring out in netbox availability
87f856c
to
4ba54c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The graphite error reporting is beautifully done, but there are some issues we should discuss/research when it comes to the chunking parts.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Closes #2345