Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to napalm 3.4.1 #2403

Merged
merged 1 commit into from
May 5, 2022
Merged

Conversation

johannaengland
Copy link
Contributor

@johannaengland johannaengland commented May 4, 2022

Closes #2381.

The old version resulted it the warning
DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.10 it will stop working
from collections import Iterable
Upgrading it to 3.4.1 fixes that and doesn't seem to influence anything else

@johannaengland johannaengland requested review from lunkwill42 and hmpf May 4, 2022 08:34
@johannaengland johannaengland self-assigned this May 4, 2022
@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #2403 (21924fd) into master (50a4e7b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2403   +/-   ##
=======================================
  Coverage   52.54%   52.54%           
=======================================
  Files         552      552           
  Lines       40151    40151           
=======================================
  Hits        21099    21099           
  Misses      19052    19052           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50a4e7b...21924fd. Read the comment docs.

@github-actions
Copy link

github-actions bot commented May 4, 2022

Test results

     12 files       12 suites   11m 40s ⏱️
3 077 tests 2 981 ✔️   96 💤 0
8 706 runs  8 418 ✔️ 288 💤 0

Results for commit 21924fd.

♻️ This comment has been updated with latest results.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, we don't have the worlds best test coverage, so it helps to check out the changelog of a library before attempting an upgrade.

I had a hard time finding one for NAPALM, so for future reference, it appears they just use GitHub releases as their changelog: https://github.com/napalm-automation/napalm/releases

There doesn't seem to be anything fishy in the changelog between 3.0 and 3.4, so I'd say this is probably fine.

@lunkwill42 lunkwill42 added this to the 5.4.0 milestone May 5, 2022
@johannaengland johannaengland merged commit cacf462 into Uninett:master May 5, 2022
@johannaengland johannaengland deleted the collections branch May 5, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants