New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize SeedDB vlan listing queries #2402

Merged

johannaengland merged 1 commit into Uninett:master from johannaengland:seeddb-vlan

May 4, 2022

Contributor

johannaengland commented May 3, 2022

Similar to #2384 in regards to #2156 this PR optimizes the vlan listing queries of SeedDB.

johannaengland requested review from hmpf and lunkwill42

May 3, 2022 13:49

johannaengland self-assigned this

codecov bot commented May 3, 2022 •

edited

Loading

Codecov Report

Merging #2402 (28a6af9) into master (31d59e6) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #2402   +/-   ##
=======================================
  Coverage   52.55%   52.55%           
=======================================
  Files         552      552           
  Lines       40152    40152           
=======================================
  Hits        21100    21100           
  Misses      19052    19052

Impacted Files	Coverage Δ
python/nav/web/seeddb/page/vlan.py	`59.57% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31d59e6...28a6af9. Read the comment docs.

github-actions bot commented May 3, 2022 •

edited

Loading

Test results

    12 files     12 suites 11m 32s ⏱️
3 077 tests 2 981 ✔️   96 💤 0 ❌
8 706 runs 8 418 ✔️ 288 💤 0 ❌

Results for commit 28a6af9.

♻️ This comment has been updated with latest results.


          Optimize SeedDB vlan listing queries

28a6af9

johannaengland force-pushed the seeddb-vlan branch from ac28f0e to 28a6af9 Compare

May 4, 2022 07:18

sonarqubecloud bot commented May 4, 2022

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

lunkwill42 approved these changes

View reviewed changes

Member

lunkwill42 left a comment

Nice, this reduced the number of queries from 9000 to 5 on my copy of a production data set 👍

lunkwill42 added this to the 5.4.0 milestone

johannaengland merged commit cbaaa19 into Uninett:master

johannaengland deleted the seeddb-vlan branch

May 4, 2022 10:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet