Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to django 3.2 for docs #2399

Merged

Conversation

johannaengland
Copy link
Contributor

As noticed in #2396 nav runs on django 3.2, but the docs use django 2.2.
This changes it so that #2396 works.

@johannaengland johannaengland requested review from lunkwill42 and hmpf May 3, 2022 10:55
@johannaengland johannaengland self-assigned this May 3, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #2399 (b995d09) into master (83a7835) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2399      +/-   ##
==========================================
- Coverage   52.55%   52.51%   -0.04%     
==========================================
  Files         552      552              
  Lines       40152    40152              
==========================================
- Hits        21100    21087      -13     
- Misses      19052    19065      +13     
Impacted Files Coverage Δ
python/nav/ipdevpoll/pool.py 84.88% <0.00%> (-5.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83a7835...b995d09. Read the comment docs.

@github-actions
Copy link

github-actions bot commented May 3, 2022

Test results

     12 files       12 suites   10m 54s ⏱️
3 077 tests 2 981 ✔️   96 💤 0
8 706 runs  8 418 ✔️ 288 💤 0

Results for commit b995d09.

Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! :)

@lunkwill42 lunkwill42 merged commit 31d59e6 into Uninett:master May 4, 2022
@lunkwill42 lunkwill42 added this to the 5.4.0 milestone May 4, 2022
@johannaengland johannaengland deleted the update-django-readthedocs branch May 4, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants