Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate more secure API tokens #2377

Merged
merged 1 commit into from
Mar 30, 2022
Merged

Generate more secure API tokens #2377

merged 1 commit into from
Mar 30, 2022

Conversation

johannaengland
Copy link
Contributor

Closes #2366.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Mar 29, 2022 •
edited
Loading

Codecov Report

Merging #2377 (7fabaab) into master (a1a6a15) will increase coverage by 0.00%.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##           master    #2377   +/-   ##
=======================================
  Coverage   52.56%   52.57%           
=======================================
  Files         552      552           
  Lines       40106    40104    -2     
=======================================
+ Hits        21083    21084    +1     
+ Misses      19023    19020    -3
Impacted Files Coverage Δ
python/nav/util.py 76.72% <50.00%> (+1.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1a6a15...7fabaab. Read the comment docs.

@github-actions
Copy link

Test results

     12 files       12 suites   13m 59s ⏱️
3 077 tests 2 981 ✔️   96 💤 0 ❌
8 706 runs  8 418 ✔️ 288 💤 0 ❌

Results for commit 7fabaab.

@johannaengland johannaengland self-assigned this Mar 29, 2022
@johannaengland johannaengland merged commit d0e14cf into Uninett:master Mar 30, 2022
@johannaengland johannaengland deleted the secure-api-token branch March 30, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmpf hmpf hmpf approved these changes

@lunkwill42 lunkwill42 Awaiting requested review from lunkwill42

Assignees

@johannaengland johannaengland

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate more secure API tokens
2 participants
@johannaengland @hmpf