Include all ethernet interface types used in the wild in the room interface listing #2314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because: - Although RFC 3635 specifies that implementations MUST use ifType=ethernetCsmacd(6) for all ethernet-like interface types, many fielded implementations have incorrectly used other values that were never reserved by the IETF. - D-Link is one such vendor, where interfaces would not be listed in the room interface list because of this. Fixes Uninett#2280
lunkwill42
force-pushed
the
bugfix/room-interfaces-interfacetypes
branch
from
cdb77b3 to
fcc5690
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #2314 +/- ##
=======================================
Coverage 58.07% 58.07%
=======================================
Files 552 552
Lines 40206 40207 +1
=======================================
+ Hits 23349 23350 +1
Misses 16857 16857
Continue to review full report at Codecov.
|
hmpf
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ifType=ethernetCsmacd(6)for all ethernet-like interface types, many fielded implementations have incorrectly used other values that were never reserved by the IETF.Fixes #2280
Replaces #2283, which was accidentally closed beyond recovery when the old stable branch was removed