Massively reduce the number of queries produced by the API /alert endpoint #2063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because: - We get to clean up a lot of code when the unresolved() filter can be used anwhere in the AlertHistory queryset chain.
Because: - This method may be called several times per object in the API, but it never changes. Might as well cache the results.
Because: - The alert API endpoint generates an unnecessary amount of subqueries, which slows things down as the number of active alerts increases. This more than halves the number of queries involved. The biggest obstacle left is the massive amounts of maintenance status queries, which aren't as easily prefetched using querysets.
hmpf
approved these changes
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.