Added option for showing origin in machinetracker #1541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a checkbox for displaying which router the data originated from.
lunkwill42
requested changes
Jul 28, 2017
| @@ -64,6 +67,9 @@ | |||
| {{ row.end_time|date:"Y-m-d H:i:s" }} | |||
| {% endif %} | |||
| </td> | |||
| {% if form_data.origin %} | |||
| <td>{{row.netbox}}</td> | |||
There was a problem hiding this comment.
Actually, it would be better to utilize row.sysname here, which is a copy of the router's sysname at the time the record was created. This way, if the netbox is deleted, old log rows will still make sense to the end user.
Changed from sisplaying row.netbox to row.sysname, because the latter will still be available even if the netbox is deleted.
lunkwill42
reviewed
Aug 7, 2017
There was a problem hiding this comment.
This looks good, but I'd like to nitpick on the checkbox vs. the column header. The checkbox says Origin, while the column header says Router.
I would suggest maybe use Source for both of them, but I'll let @jmbredal weigh in on the matter as well...
lunkwill42
approved these changes
Aug 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a checkbox for displaying which router the data originated from.
Fixes #1506