Fix oceandata hyrax catalog issues #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of splitting on the path, just explicitly recombine the schema and the netloc.
THREDDS Client Catalog spec explicitly says that the service base and the urlpath should be concatenated directly. So avoid using urljoin(), which was treating the urlpath as an absolute path on the server. This breaks a weird link in a ramadda catalog. Just adjust the test for ramadda and treat its urlpath (with full server) as a bug.
One block of code was not correctly mapping service *type* to url, leaving 'dap' in the access_urls dict, rather than 'opendap'.
DODS is considered an alias for OPENDAP. Also add (legacy) support for 'http' as a synonym for HTTPServer.
dopplershift
force-pushed
the
fix-724
branch
from
146c46e to
b4350d5
Compare
lesserwhirls
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
urljoin(). This breaks handling of urlpath in the Ramadda catalog "opendap link", but at this point I consider that a Ramadda bug, not something actually allowed by the TDS Client Catalog Spec, which explicitly states that the service base and the urlpath should be directly concatenatedremote_access(). It turned out we were improperly mapping this url to the service type, and using the service name insteadremote_access()andaccess_with_service()methodsChecklist