Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Fix WyomingUpperAir height folding #696

Merged
merged 1 commit into from
May 23, 2023

Conversation

dcamron
Copy link
Member

@dcamron dcamron commented May 23, 2023

Pandas read_fwf only infers column widths based on the first 100 rows, leading to cut off values in later rows. Define column widths explicitly fixes this. Cut off after 8 columns since we ignore those anyway.

Thanks to the issue report in the python-users unidata mailing list and credit to @kgoebber for similar solution and test changes/additions.

Checklist

  • Tests added

Pandas `read_fwf` only infers column widths based on the first 100
rows, leading to cut off values in later rows. Define column widths
explicitly fixes this.
Copy link
Member

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Failures look completely unrelated, so while they could use fixing, that will have to wait.

@dopplershift dopplershift merged commit 233013d into Unidata:master May 23, 2023
@dcamron dcamron deleted the height-folding branch May 23, 2023 21:38
@dopplershift dopplershift added this to the 0.10 milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants