Set log level in each module instead of using logging.basicConfig #478
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This PR sets the logging level using the module-level loggers instead of using
logging.basicConfig(level=)
.Running
grep -Rn logging.basicConfig --include=*.py
in the root directory of the repo should return nothing now. To check that this solved the issue, try running the following code without the changes, and then with the changes:Without the changes, two log messages should appear for each logger call greater than debug. One message will be formatted according to the formatter in the code above and the other will be unformatted. With the changes, only the formatted log messages should appear.
Checklist