If TDSCatalog detects html, warn and try an XML link. #32
Conversation
dopplershift
force-pushed
the
html-warning
branch
from
9ec0b34 to
47d76e7
Compare
|
|
||
| # If we were given an HTML link, warn about it and try to fix to xml | ||
| if 'html' in resp.headers['content-type']: | ||
| import warnings |
There was a problem hiding this comment.
Why the warnings package and not logging.warning?
There was a problem hiding this comment.
The logic that was suggested before was: logging for warnings of bad conditions that the user may want to know about, but can't do anything about; warnings module for warnings the user should address.
https://docs.python.org/3/howto/logging.html
Specifically: "warnings.warn() in library code if the issue is avoidable and the client application should be modified to eliminate the warning"
There was a problem hiding this comment.
Ah yes, I remember now.
|
My bigger question, is automatically trying a new URL and setting that on the |
|
I think it's ok to try with xml if the url ends with html. It's a very common cut/paste error when trying to find a catalog url. |
|
Not just url endswith html, I replace all 'html' in the URL with 'xml'. This is important for URLs like: http://thredds.ucar.edu/thredds/catalog/grib/NCEP/GFS/Global_onedeg/catalog.html?dataset=grib/NCEP/GFS/Global_onedeg/Best |
|
Ah. Yes. I think that is still ok to do. |
If TDSCatalog detects html, warn and try an XML link.
Fixes #29.