Add capability to deal with stations with no identifier from Wyoming

[jrleeman]

Closes #238

Deals with missing lines from the wyoming archive when the station has a number, but no identifier.

[dopplershift]

You couldn't instead check:

lines[1].startswith('Station identifier')

?

[jrleeman]

Could sure

[dopplershift]

Just seems like it could change from 26 lines for a variety of reasons.

[jrleeman]

Sure, but we'll break on all of them 😭
Push coming.

[dopplershift]

Current check just seems pretty brittle...would be good to check for the exact condition that's missing.

[jrleeman]

Happy to change it, though I don't really see it being more or less brittle as any other weirdness in the footer will still break things. I'll revise now.

[jrleeman]

Ok, not quite as easy as your startswith because we have a lot of leading whitespace and the field is totally missing, not just unpopulated. Anywho, this should do the trick.

[dopplershift]

Right, if it's missing then (now accounting for whitespace) lines[1].strip().startswith('Station identifier:') should return False, no? Your new way is fine, I just wasn't sure if there was something else I'm missing.

[jrleeman]

The whitespace... It would have to have 28 leading whitespaces on the string. Ugly.

[dopplershift]

Is there a reason the strip() call wouldn’t remove the need to hard-code the spaces?

[jrleeman]

Probably not. Is there any reason that .strip().startswith('...') is better/worse than if 'foo' in bar: ?

[dopplershift]

That’s fine. But my original suggestion was to look for “Station Identifier” to be missing from lines[1], yours is to look only for “Station number” there. I just was confused as to why my approach, which is checking directly for the case that you’re solving, wouldn’t work.

Either way is fine, and I don’t want to bike she’d this to death. Just trying to see if I’m missing something.

[jrleeman]

I just think this is a bit clearer and they both accomplish the same task with the same complexity as far as I can tell. Tomato vs Tomato?