Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

corrected bug where na_values were bypassed #219

Merged
merged 4 commits into from
Apr 12, 2018
Merged

corrected bug where na_values were bypassed #219

merged 4 commits into from
Apr 12, 2018

Conversation

danielmwatkins
Copy link
Contributor

@danielmwatkins danielmwatkins commented Apr 11, 2018 •
edited
Loading

I learned that Pandas uses functions in the converters dictionary prior to applying the na_values, so I added a check for na_values inside my converter function.

dopplershift
dopplershift approved these changes Apr 12, 2018
View reviewed changes
Copy link
Member

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward to me.

@dopplershift dopplershift added this to the 0.8 milestone Apr 12, 2018
@dopplershift dopplershift merged commit 7a332b6 into Unidata:master Apr 12, 2018
@dopplershift dopplershift mentioned this pull request Apr 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

@jrleeman jrleeman Awaiting requested review from jrleeman

@lesserwhirls lesserwhirls Awaiting requested review from lesserwhirls lesserwhirls is a code owner

Assignees
No one assigned
Labels
Area: Web Services Type: Bug
Projects
None yet
Milestone
0.8
Development

Successfully merging this pull request may close these issues.
2 participants
@danielmwatkins @dopplershift