Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT: Remove calls to dict.keys() #195

Merged
merged 1 commit into from
Mar 20, 2018
Merged

MNT: Remove calls to dict.keys() #195

merged 1 commit into from
Mar 20, 2018

Conversation

dopplershift
Copy link
Member

For most cases it's completely unnecessary and longer. Just iterate over the dict directly.

@dopplershift
MNT: Remove calls to dict.keys()
5545faa 
For most cases it's completely unnecessary and longer. Just iterate over
the dict directly.
@dopplershift dopplershift added this to the 0.7 milestone Mar 20, 2018
jrleeman
jrleeman approved these changes Mar 20, 2018
View reviewed changes
Copy link
Contributor

@jrleeman jrleeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay for less code!

@jrleeman jrleeman merged commit 5c306c4 into Unidata:master Mar 20, 2018
@dopplershift dopplershift deleted the remove-keys branch March 20, 2018 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrleeman jrleeman jrleeman approved these changes

@lesserwhirls lesserwhirls Awaiting requested review from lesserwhirls lesserwhirls is a code owner

Assignees
No one assigned
Labels
Type: Maintenance
Projects
None yet
Milestone
0.7
Development

Successfully merging this pull request may close these issues.
2 participants
@dopplershift @jrleeman