Change line 44 to include 0123 for day instead of 012 #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjpokran
requested review from
dopplershift,
jrleeman and
lesserwhirls
as code owners
|
|
|
Apparently I commited this with the wrong email address.. Not sure how to get around that.. I signed the CLA with my github account, but that's associated with a different email than what I commited the change with.. ([email protected], which is not even a valid email addr...) How can I fix this? |
|
Try running this: Then do: |
|
🎉 Are you interested in trying to write a test? Otherwise, (if you don’t mind) I can knock one out real quick and push to your branch. |
|
I'm not really sure where to start with that.. I'd appreciate it. Seeing one written, hopefully I can swing the next one. Thx! |
dopplershift
added a commit
to pjpokran/siphon
that referenced
this pull request
Dec 4, 2017
dopplershift
approved these changes
Dec 5, 2017
|
Probably should have @lesserwhirls or @jrleeman sign off since I've now committed on this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #172 so that filter_time_nearest searches for days 30 and 31 work properly.