Printing/repr improvements #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enhances behavior in the notebook.
This just prints out a list of the datasets, which is pretty much what you always want.
dopplershift
requested review from
jrleeman and
lesserwhirls
as code owners
|
|
|
Well that makes me feel good, a combination of deleting our old Python 3.7 netCDF4 package and fixing a stupid test gets us green on the Python 3.7 nightly build. |
No clue why it was ever deemed a good idea to use string representation of a value to check this (maybe no numpy dependence at the time?), but it's breaking on Python 3.7. Move to a proper test with assert_almost_equal.
dopplershift
force-pushed
the
printing
branch
from
f88ba03 to
d61756c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has a few improvements to string representations and printing to help when working interactively (i.e. in the notebook)
__repr__(which is just the same as__str__) toDatasetand friends for the CDM Remote interface. This just makes it easier to get to them in the notebook__str__method tocatalog.datasetsto make it easier to print out what datasets are available without needing to manually calllist.