BUG: Fix access_urls for some services #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catalogs are allowed to specify the name of a service that is contained within a compound service. Siphon was not properly creating the access urls dictionary for this case.
jrleeman
approved these changes
Sep 6, 2017
| service_name = metadata['serviceName'] | ||
| all_service_dict = {} | ||
| for service in all_services: | ||
| all_service_dict[service.name] = service |
There was a problem hiding this comment.
Should this be in an else? (i.e. should the compound service be in the dictionary or just it's sub services?)
There was a problem hiding this comment.
You want both. I initially had it as an else, and it (rightly) failed tests.
Seems that we weren't using the right variable to point to the 64-bit conda, so we were running 32-bit conda on 64-bit platforms. Oops.
We've asked CodeCov to track this, so we should probably no longer ignore coverage results for the test files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catalogs are allowed to specify the name of a service that is contained
within a compound service. Siphon was not properly creating the access
urls dictionary for this case.