Modernize infrastructure #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always upload coverage results (regardless of success/failure). Also include information about platform and python version to make distinguishing builds on codecov easier.
This allows us to click on builds and see failing tests.
This is the first stage of moving to sphinx-gallery.
This makes us compatible with sphinx-gallery.
This is a simpler way to do lint checking.
dopplershift
force-pushed
the
infra-updates
branch
from
0016085 to
b8ba5fd
Compare
dopplershift
force-pushed
the
infra-updates
branch
4 times, most recently
from
74e9fc2 to
33fa728
Compare
This accounts for moving linting to pytest-flake8 and for the fact that the doc build also handles running examples.
dopplershift
force-pushed
the
infra-updates
branch
from
33fa728 to
f0ece7f
Compare
This didn't catch anything other than a few suboptimal comprehensions.
Also add flake8 plugin for checking copyright.
Also enable flake8-pep3101.
Also enable flake8-import-order.
lesserwhirls
approved these changes
Mar 20, 2017
|
Ready to be merged @dopplershift? |
|
@lesserwhirls Was going to:
|
|
That works. Just let me know. |
Also enable flake8-quotes.
This will also get us the examples on Windows.
With only the last 50 revisions, we might not get enough for git describe to work.
dopplershift
force-pushed
the
infra-updates
branch
2 times, most recently
from
e6b8899 to
c897be2
Compare
CartoPy "plotting" extra pulls in GDAL, which is just a step too far for us to install just to run examples.
dopplershift
force-pushed
the
infra-updates
branch
from
c897be2 to
f45e757
Compare
|
I think this is good to go now. |
|
codecov is failing, but just barely (down 0.01%). I'd merge it in as is, but I don't have permissions on github to override the check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is bringing us up to date with what I consider "current" infrastructure: