Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suport netCDFServer name #215

Closed
jrleeman opened this issue Apr 6, 2018 · 2 comments
Closed

Suport netCDFServer name #215

jrleeman opened this issue Apr 6, 2018 · 2 comments

Comments

@jrleeman
Copy link
Contributor

jrleeman commented Apr 6, 2018

When using NCEI data, they use the older name for NCSS. This makes workshop materials more complicated and requires too much knowledge of the data source for users. We thought this was in 0.7 😭

@lesserwhirls
Copy link
Collaborator

There are a couple of ways to go about this. Probably the best way, from an end users point of view, would would involve making sure that this just works©™®:

ncss = dataset.subset()

To do so, we could add a check in the KeyError except:

siphon/siphon/catalog.py

Lines 592 to 596 in 935d195

try:
return provider(self.access_urls[service])
except KeyError:
raise ValueError(service + ' is not available for this dataset')

and check to see if

  1. service is NetcdfSubset and
  2. if self.access_urls contains NetcdfServer

If both are true, then we use use NetcdfServer as the service. Otherwise, raise the ValueError as we currently do.

dopplershift added a commit to dopplershift/siphon that referenced this issue Apr 9, 2018
Adds support for NetcdfServer, when available, to be used for NCSS.
@dopplershift
Copy link
Member

dopplershift commented Apr 9, 2018

See #216 for what seemed to be least horrible to me.

dopplershift added a commit to dopplershift/siphon that referenced this issue Apr 9, 2018
Adds support for NetcdfServer, when available, to be used for NCSS.
dopplershift added a commit to dopplershift/siphon that referenced this issue Apr 9, 2018
Adds support for NetcdfServer, when available, to be used for NCSS.
dopplershift added a commit to dopplershift/siphon that referenced this issue Apr 9, 2018
Adds support for NetcdfServer, when available, to be used for NCSS.
dopplershift added a commit to dopplershift/siphon that referenced this issue Apr 10, 2018
Adds support for NetcdfServer, when available, to be used for NCSS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants