MNT: Fix unicode issues on Python 2.7

Pass the raw response content, rather than decoded text, to the element tree parser. This allows the parser to detect the encoding using the standard xml tags.
Unidata · Nov 1, 2017 · fd60234 · fd60234
1 parent 39029b0
commit fd60234
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/siphon/catalog.py b/siphon/catalog.py
@@ -186,7 +186,7 @@ def __init__(self, catalog_url):
             resp.raise_for_status()
 
         # begin parsing the xml doc
-        root = ET.fromstring(resp.text)
+        root = ET.fromstring(resp.content)
         self.catalog_name = root.attrib.get('name', 'No name found')
 
         self.datasets = DatasetCollection()

diff --git a/siphon/radarserver.py b/siphon/radarserver.py
@@ -85,7 +85,7 @@ def _get_metadata(self):
 
     def _get_stations(self, station_file='stations.xml'):
         resp = self.get_path(station_file)
-        self.stations = parse_station_table(ET.fromstring(resp.text))
+        self.stations = parse_station_table(ET.fromstring(resp.content))
 
     def query(self):
         """Return a new query for the radar server.