-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise a more informative error when pickling #602
Comments
How about adding a
|
Yes, that would be great! |
see pull request #604 |
jswhit
added a commit
that referenced
this issue
Nov 8, 2016
raise NotImplementedError when trying to pickle extension objects (issue #602)
pull request #604 merged |
Thanks Jeff! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
pickle is Python's default serialization method, so lots of libraries use it.
netCDF4 does not support pickle, which is actually pretty reasonable -- it's not obvious how to (de)serialize a netCDF file (e.g., just with the filename, or with a complete image of the file?).
But, we should raise more informative errors when pickling Dataset/Variable objects. For example, netCDF4 currently produces hard to interpret error messages (
RuntimeError: NetCDF: Not a valid ID
) only after attempted access to data from a pickled/unpicklednetCDF4.Variable
: dask/distributed#629CC @mrocklin @pwolfram
The text was updated successfully, but these errors were encountered: