Merge pull request #839 from Unidata/issue836

always use nc_get_vars for strided access over http (issue #836)
Unidata · Aug 24, 2018 · a5e26f3 · a5e26f3
2 parents 151ccb3 + 4ebf6d6
commit a5e26f3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/Changelog b/Changelog
@@ -4,6 +4,7 @@
  * make sure format keyword not ignored when mode is 'ws' (issue #827)
  * fix numpy FutureWarning (non-tuple sequence for     
    multidimensional indexing is deprecated), issue #833.
+ * always use nc_get_vars for strided access over OpenDAP (issue #838).
 
  version 1.4.1 (tag v1.4.1rel)
 =============================

diff --git a/netCDF4/_netCDF4.pyx b/netCDF4/_netCDF4.pyx
@@ -3649,7 +3649,9 @@ behavior is similar to Fortran or Matlab, but different than numpy.
         # avoid calling nc_get_vars for strided slices by default.
         # a fix for strided slice access using HDF5 was added
         # in 4.6.2.
-        if __netcdf4libversion__ >= "4.6.2":
+        # always use nc_get_vars for strided access with OpenDAP (issue #838).
+        if __netcdf4libversion__ >= "4.6.2" or\
+           self._grp.filepath().startswith('http'):
             self._no_get_vars = False
         else:
             self._no_get_vars = True