-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Bufr data support including multi-category messages #1396
base: maint-5.x
Are you sure you want to change the base?
Conversation
…le data file, so that prepbufr was supported. Also CMA bufr tables were added.
Greetings @Yaqiang! Thank you for this contribution! There are two issues at play with the github checks. This first is minor, in that there are some issues detected with the code style. These can be seen by running The second is there are failing tests. It looks like there is a test failing due to an error trying to reach a remote server (unrelated to your pull requests). I ran our full testsuite against your PR and did find some failures related to the changes, however. For example, when trying to read a sequence from the attached
we get the following error:
I'm going to open a PR here shortly to disable the failing tests when running on GitHub (we've seen connectivity issues with this server before when running on GitHub), so that should help clear up the GitHub checks. |
GitHub appears to have intermittent access issues when running a dap2 test against iridl.ldeo.columbia.edu (see Unidata#1396 (comment)). Disable this specific test for pull requests, but still run locally and on jenkins. Also, they have upgraded their server to support https, so we will use that in the test.
@lesserwhirls Thanks for you review and helpful information on this PR! I mentioned that the check is failling but unfortunatelly I am very busy in these days to response quickly. Can you comment me how to do in next step? Also you mentioned the file "ecmwf-wmo16-hasOptionalSection.bufr" which I didn't find here. Otherwise I will debug the problem on this file. |
Ah, yes, I forgot to attach the file! Here it is: ecmwf-wmo16-hasOptionalSection.bufr.zip These would be my suggestion for the next steps:
Thank you again! |
Enhance Bufr data support including multi-category messages in a sigle data file, so that prepbufr data file is supported. Also CMA bufr tables were added for reading CMA released bufr data files.
Description of Changes
_ Add CMA bufr tables (table B and D) as resource tables for reading the bufr data files released from CMA.
_ prepbufr data file may containes multiple category messages such as ADPUPA, ADPSFC, etc. BufrIosp2 only support single category messages before. So BufrIosp2 and related classes (BufrIospBuilder, EmbeddedTable, TableA, ...) was revised to support more root variables (not just 'obs').
_ 'reallyRead' function in ucar.nc2.Variable class has problem when a Structure variable read result is ArrayObject with ArraySequence as elements, so it was revised to solve the issue.
I test them using MeteoInfoLab (version 3.9.7) bufr reading scripts with netcdf library behand.
PR Checklist
until ready for review