Classifier #1353
Merged
Classifier #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
matakleo
commented
Jun 6, 2024
| @@ -939,6 +943,10 @@ private void createEnhancements() { | |||
| if (normalizerAtt != null && this.enhanceMode.contains(Enhance.ApplyNormalizer) && dataType.isFloatingPoint()) { | |||
| this.normalizer = Normalizer.createFromVariable(this); | |||
| } | |||
| Attribute classifierAtt = findAttribute(CDM.CLASSIFY); | |||
| if (classifierAtt != null && this.enhanceMode.contains(Enhance.ApplyClassifier) && dataType.isFloatingPoint()) { | |||
There was a problem hiding this comment.
check if numeric instead of if floating point (isNumeric)
matakleo
commented
Jun 6, 2024
| } | ||
| } | ||
|
|
||
| public static Classifier createFromArray(Array arr, DataType type) { |
There was a problem hiding this comment.
this can be deleted
matakleo
commented
Jun 6, 2024
| /** wEmpty in case data not good */ | ||
| public Classifier() {} | ||
|
|
||
| private Classifier(Array arr, DataType type) { |
There was a problem hiding this comment.
probably just one constructor is enough
matakleo
commented
Jun 6, 2024
| } | ||
|
|
||
| /** Classify double array */ | ||
| public int[] classifyDoubleArray(Array arr) { |
There was a problem hiding this comment.
keep only the double method, the int and float are not really used
There was a problem hiding this comment.
instead of the if clauses, call your one-val method change
matakleo
commented
Jun 6, 2024
| } | ||
|
|
||
| /** for a single float */ | ||
| public int classifyArray(float val) { |
There was a problem hiding this comment.
keep also only double
matakleo
commented
Jun 6, 2024
| <values>1.0 -2.0 0.0 4.0 -5.0</values> | ||
| </variable> | ||
|
|
||
| <variable name="intPositives" shape="5" type="int"> |
There was a problem hiding this comment.
do the other two tests for ints as well
matakleo
commented
Jun 6, 2024
| } | ||
|
|
||
| /** enhance is not applied to Integers, so we expect the same values after application */ | ||
| @Test |
There was a problem hiding this comment.
add some more test here
haileyajohnson
force-pushed
the
Classifier
branch
from
56727d0 to
1ed0023
Compare
haileyajohnson
approved these changes
Jun 6, 2024
| <attribute name="classify"/> | ||
| <values>1.0 -2.0 0.0 4.0 -5.0</values> | ||
| </variable> | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Added a Classifier class into filters. It serves as a classifier which assigns 0 to negative numbers and 1 to positives and zero. [e.g. x>=0 --> 1 | x<0 --> 0]
PR Checklist
until ready for review