Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use _ARRAY_DIMENSIONS to create shared, named dimensions in ZarrHeader #1325

Merged
merged 4 commits into from
Apr 4, 2024
Merged

Conversation

rschmunk
Copy link
Contributor

@rschmunk rschmunk commented Mar 27, 2024

Description of Changes

This PR adds code to the ZarrHeader class to look for the xarray/geozarr _ARRAY_DIMENSIONS attribute and, if present, use it to name a variable's dimensions and to create shared dimensions with the variable's group.

This is a first effort to see how much code/effort was necessary and may not consider cases where this info should be explicitly be ignored, or if there are additional Exceptions that one needs to watch for.

PR Checklist

  • Link to any issues that the PR addresses
  • Add labels
  • Open as a draft PR
    until ready for review
  • Make sure GitHub tests pass
  • Mark PR as "Ready for Review"

Copy link
Contributor

@haileyajohnson haileyajohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually needs more unit tests for Zarr/NcZarr but happy to merge this now since zarr is still "experimental" atm (without the zarr modules added to the fat jar)

@@ -52,6 +52,8 @@ dependencies {
netcdfAll project(':cdm:cdm-image')
netcdfAll project(':cdm:cdm-radial')
netcdfAll project(':cdm:cdm-misc')
netcdfAll project(':cdm:cdm-s3')
netcdfAll project(':cdm:cdm-zarr')
netcdfAll project(':bufr')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're not ready to include these in the fatJar by default :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haileyajohnson, I know. Half the time when I'm pushing my copy of the repo from Xcode to Github, I forget to uncheck the box for that file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured :)

@haileyajohnson haileyajohnson merged commit 5d9d864 into Unidata:maint-5.x Apr 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants