-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use _ARRAY_DIMENSIONS to create shared, named dimensions in ZarrHeader #1325
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventually needs more unit tests for Zarr/NcZarr but happy to merge this now since zarr is still "experimental" atm (without the zarr modules added to the fat jar)
gradle/root/fatJars.gradle
Outdated
@@ -52,6 +52,8 @@ dependencies { | |||
netcdfAll project(':cdm:cdm-image') | |||
netcdfAll project(':cdm:cdm-radial') | |||
netcdfAll project(':cdm:cdm-misc') | |||
netcdfAll project(':cdm:cdm-s3') | |||
netcdfAll project(':cdm:cdm-zarr') | |||
netcdfAll project(':bufr') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we're not ready to include these in the fatJar by default :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@haileyajohnson, I know. Half the time when I'm pushing my copy of the repo from Xcode to Github, I forget to uncheck the box for that file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I figured :)
Description of Changes
This PR adds code to the ZarrHeader class to look for the xarray/geozarr _ARRAY_DIMENSIONS attribute and, if present, use it to name a variable's dimensions and to create shared dimensions with the variable's group.
This is a first effort to see how much code/effort was necessary and may not consider cases where this info should be explicitly be ignored, or if there are additional Exceptions that one needs to watch for.
PR Checklist
until ready for review