Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test #1262

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Improve test #1262

merged 3 commits into from
Nov 22, 2023

Conversation

tdrwenski
Copy link
Contributor

@tdrwenski tdrwenski commented Nov 21, 2023 •
edited
Loading

Description of Changes

  • remove unused code
  • use google truth asserts
  • add NeedsExternalResource category since the test uses the thredds-dev server. This will prevent it from being run on GitHub PRs.

@tdrwenski tdrwenski marked this pull request as ready for review November 21, 2023 21:43
@tdrwenski tdrwenski merged commit 64bd4be into Unidata:maint-5.x Nov 22, 2023
9 checks passed
@tdrwenski tdrwenski deleted the improve-test branch November 22, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haileyajohnson haileyajohnson haileyajohnson approved these changes

@DennisHeimbigner DennisHeimbigner Awaiting requested review from DennisHeimbigner DennisHeimbigner is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tdrwenski @haileyajohnson