Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intermediate PR: Handle multiple different time and altitude axes for GridAsPoint writer #1250

Merged
merged 9 commits into from
Oct 24, 2023
Merged

Intermediate PR: Handle multiple different time and altitude axes for GridAsPoint writer #1250

merged 9 commits into from
Oct 24, 2023

Conversation

mnlerman
Copy link
Contributor

@mnlerman mnlerman commented Oct 19, 2023 •
edited
Loading

This is a good breaking point to submit changes associated with Unidata/tds#269

Tasks completed in this pull request:

  • Add timeName attribute to DsgFeatureCollection
  • And altName attribute to DsgFeatureCollection
  • Add constructors to pass timeName and altName up through the inheritance tree
  • Assign timeName and altName attributes for
  • Tests to confirm that altName and timeName are assigned correctly for CoverageAsPoint and CoverageAsProfile
  • Rework Point writer and StationCollection writer to write the actual axis names rather than generic names

Work still to be completed:

  • Rework StationProfileCollectionWriter to write the actual axis names rather than generic names
  • Rework ProfileCollectionWriter to write the actual axis names rather than generic names

PR Checklist

  • Link to any issues that the PR addresses
  • Add labels
  • Open as a draft PR
    until ready for review
  • Make sure GitHub tests pass
  • Mark PR as "Ready for Review"

@mnlerman
Add timeName and altName attributes.
10575cd 
Use and assign the attributed where needed.
Write headers and records to use new timeName and altNames .
@mnlerman mnlerman changed the title Intermediate PR: Handle multiple different time and altitude axes for GridAsPoint writer 2 Intermediate PR: Handle multiple different time and altitude axes for GridAsPoint writer Oct 19, 2023
mnlerman and others added 3 commits October 19, 2023 12:44
@mnlerman
Merge branch 'maint-5.x' into cf-point-writer
e4c1bab
@mnlerman
Add timeName and altName attributes.
71a97a3 
Use and assign the attributed where needed.
Write headers and records to use new timeName and altNames .
@mnlerman
Merge remote-tracking branch 'origin/cf-point-writer' into cf-point-w…
1007d62 
…riter

# Conflicts:
#	cdm/core/src/main/java/ucar/nc2/ft/point/DsgCollectionImpl.java
@mnlerman mnlerman marked this pull request as ready for review October 19, 2023 22:02
@mnlerman mnlerman merged commit 915cc69 into Unidata:maint-5.x Oct 24, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haileyajohnson haileyajohnson haileyajohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mnlerman @haileyajohnson