Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support to parse variable length char element from ncml #1236

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

jmasson-l3h
Copy link
Contributor

Description of Changes

Added support to parse variable length tokens for char arrays in the ncml reader. This is to help resolve issue #1235

PR Checklist

  • Link to any issues that the PR addresses
  • Add labels
  • Open as a draft PR
    until ready for review
  • Make sure GitHub tests pass
  • Mark PR as "Ready for Review"

@CLAassistant
Copy link

CLAassistant commented Sep 19, 2023

CLA assistant check
All committers have signed the CLA.

@mnlerman
Copy link
Contributor

mnlerman commented Sep 19, 2023

@jmasson-l3h thank you for your contribution! The code looks good but please sign the CLA so that we can review and merge it.

@jmasson-l3h
Copy link
Contributor Author

@jmasson-l3h thank you for your contribution! The code looks good but please sign the CLA so that we can review and merge it.

Hello , when attempting to sign that I get "Internal Server Error" on url "https://cla-assistant.io/auth/github/callback?code=9d9c182fce4a29a1e7a6" .

Is there another mechanism to sign ?

@mnlerman
Copy link
Contributor

@jmasson-l3h
Copy link
Contributor Author

https://cla-assistant.io/Unidata/netcdf-java?pullRequest=1236 Try this link

Same issue with the internal server error. I will try on my personal computer later tonight.

@mnlerman
Copy link
Contributor

Ahh hmm, I got the internal server error when I opened the link you provided but I was able to open the one that I sent. I wonder if the problem is associated with this message from above:

Jeffrey Masson seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jmasson-l3h
Copy link
Contributor Author

Ahh hmm, I got the internal server error when I opened the link you provided but I was able to open the one that I sent. I wonder if the problem is associated with this message from above:

Jeffrey Masson seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

I was able to do it from home, was probably a network/security issue on my side.

@mnlerman mnlerman merged commit 7380a93 into Unidata:maint-5.x Sep 20, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[VERSION]: 5.5.2 Exception thrown when accessing char data from NetcdfDatasets.openNcmlDataset
3 participants