-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support to parse variable length char element from ncml #1236
Added support to parse variable length char element from ncml #1236
Conversation
@jmasson-l3h thank you for your contribution! The code looks good but please sign the CLA so that we can review and merge it. |
Hello , when attempting to sign that I get "Internal Server Error" on url "https://cla-assistant.io/auth/github/callback?code=9d9c182fce4a29a1e7a6" . Is there another mechanism to sign ? |
Same issue with the internal server error. I will try on my personal computer later tonight. |
Ahh hmm, I got the internal server error when I opened the link you provided but I was able to open the one that I sent. I wonder if the problem is associated with this message from above:
|
I was able to do it from home, was probably a network/security issue on my side. |
Description of Changes
Added support to parse variable length tokens for char arrays in the ncml reader. This is to help resolve issue #1235
PR Checklist
until ready for review