HDF4-visual studio interference #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is somehow in interference with something in the HDF4 code. So, I changed the OPAQUE -> OPAQUE_ and that appears to fix the problem with bison when HDF4 is enabled. ps. when Visual Studio complained about token 'constant' it turn out that it mean token type, not the actual token named 'constant'. Instead the actual token that was causing the problem was 'OPAQUE'.
|
I agree 100% with the critique of Visual Studio. Thanks for the diagnostic work, great catch Dennis! Will get this merged and move on to other pull requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that the token OPAQUE in ncgen.y is somehow in interference
with something in the HDF4 code. So, I changedthe OPAQUE -> OPAQUE_
and that appears to fix the problem with bison when HDF4 is enabled.
(See also #366).
I am surprised that other tokens did not also cause this problem, but
apparently not.
I should also note that Visual Studio error message leave something to be desired.
when Visual Studio complained about token 'constant' it turn out that it mean token type,
not the actual token named 'constant'. Instead the actual token that was causing the
problem was 'OPAQUE'.