Implement lazy read of some var metadata to speed file opens #1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's some results of recent speed improvements:
|
12 tasks
|
@WardF this one is ready to merge. It will improve performance at file opens. |
|
@WardF can this be merged soon? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #857.
Lazy reading of vars is harder than lazy reading of atts. However, in this PR, some of the var metadata is read as a lazy read.
This saves time on file open, and saves time overall for the user if vars are never accessed.
In order to support the netCDF model, full lazy read is not attempted. Vars are read, dimension and type information are read for each dataset, all at open. However, other metadata, like cache settings and fill value, are only read for vars when necessary.
This PR is tested and ready to merge.