Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake build does not produce pkgconfig file #5

Closed
opoplawski opened this issue Aug 27, 2013 · 4 comments
Closed

cmake build does not produce pkgconfig file #5

opoplawski opened this issue Aug 27, 2013 · 4 comments
Assignees
@WardF

Comments

@opoplawski
Copy link
Contributor

The cmake build should still produce a usable pkgconfig file.
@ghost ghost assigned WardF Nov 6, 2013
@opoplawski
Copy link
Contributor Author

I think this is the show-stopper for moving to cmake in the Fedora builds.

@WardF
Copy link
Member

WardF commented Feb 6, 2014

Thank you for the update; I've created a ticket for this in our JIRA system and will see about fixing it ASAP! https://bugtracking.unidata.ucar.edu/browse/NCF-288

@WardF
Copy link
Member

WardF commented Feb 6, 2014

Starting with commit 154c2a6, cmake-based builds are generating pkgconfig files (netcdf.pc) which are the equivalent of the netcdf.pc generated by autotools. I need to evaluate that tomorrow to see if it is sufficient.

@WardF
Copy link
Member

WardF commented Feb 7, 2014

It appears that everything is working as expected; I will make further changes to netcdf.pc configuration as issues are reported.

@WardF WardF closed this as completed Feb 7, 2014
@WardF WardF mentioned this issue Sep 22, 2014
Closed
@edhartnett edhartnett mentioned this issue Mar 21, 2016
Closed
edhartnett added a commit to NetCDF-World-Domination-Council/netcdf-c that referenced this issue Jan 30, 2018
@edhartnett
Merge pull request Unidata#5 from NetCDF-World-Domination-Council/ejh…
413071c 
…_fill_hpc

documentation updates only
DennisHeimbigner added a commit that referenced this issue Dec 6, 2018
@DennisHeimbigner
Make the netcdf-c library compile with gcc -ansi.
1a75313 
Primary fixes to get -ansi to work.
1. Convert all '//' C++ style comments to /*...*/ or to use #if 0...#endif
2. It turns out that when -ansi is specified, then a number of
   functions no longer are defined in the header -- but they are still
   in the .so file.<br>
   The big example is strdup(). So, added code to include/ncconfig.h to define
   externs for those missing functions that occur in more than one place.
   These are enabled if !_WIN32 && __STDC__ == 1 (__STDC__ is supposed to
   be the equivalent compile time flag to -ansi). Note that this requires
   config.h (which references ncconfig.h) to be included in files where it is
   currently not included. Single uses will be only in the file that uses them.
3. Added mmap test for the MAP_ANONYMOUS flag to configure.ac. Apparently
   this is not always defined with -ansi.
4. fix some large integer constants in nc_test4/tst_atts3.c and nc_test4/tst_filterparser.c
   to avoid compiler complaints.
5. fix a double constant in nc_test4/tst_filterparser.c to avoid compiler complaints.

[Note I suspect #4 and #5 will be a problem on big-endian machines, but we have no way to test]

Misc. Changes:
1. convert more instances of _MSC_VER to _WIN32.
2. added some debugging code to include/nctestserver.h
3. added comment about libdispatch/drc.c always being compiled.
4. modify parser generation in ncgen to remove unneeded files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WardF WardF

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@opoplawski @WardF