Further improvements to datetime roundtripping #225
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forget if there was a reason we did not do this before, but this applies an approach I took in xarray (pydata/xarray#4684) to improve the accuracy of roundtripping
np.datetime64[ns]
dates tocftime.datetime
objects. The changes here would mean that we'd do our absolute best to retain an integer dtype when encoding times throughdate2num
.I've included a pretty challenging test that passes on my machine;
however it may not be a valid test on 32-bit systems.Edit: I updated the PR for what I think should allow things to pass on Windows.