Raise ValueError upon construction of invalid datetime object #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #8 and #9
This PR switches
netcdftime.datetime
from pointing toDatetimeProlepticGregorian
to the genericnetcdftime._netcdftime.datetime
object and adds logic to raise aValueError
if a constructed date is out of bounds for a given calendar.Locally all the tests pass when I make these changes, but I'm not sure if they have unintended consequences for netcdftime or netcdf4-python. Please let me know if you have any comments or suggestions on my implementation. In particular, this is my first time working with cython; hopefully what I have here is a decent start. Many thanks.