No longer support replacing dayofwk and dayofyr #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like you version better - removing the other pull request. |
|
Thanks! This should be ready to merge once the CI finishes if you have no further comments. |
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #106
Thanks @jswhit -- this is sort of what I had in mind. Here I simply no longer propagate the old
dayofyranddayofwkattributes from the original date to the new one. I'm not sure if there was a use-case for replacing thedayofyranddayofwkattributes of a date, since they are intrinsic properties of a given datetime.I added a couple tests to this implementation too. I'm happy to make any changes if you have any comments.