Removals of all deprecated stuff #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This really should have been done when we deprecated it. Oops.
More places where degC became degrees_Celsius. Since this isn't an important part of the test, just set the label and be done.
dopplershift
added
Area: Calc
jthielen
requested changes
Jan 10, 2020
There was a problem hiding this comment.
Here's the main thing you appeared to have missed in xarray.py:
require_1d_coord = ['time', 'vertical'] # TODO: Add 'y', 'x' in v1.0should be updated to
require_1d_coord = ['time', 'vertical', 'y', 'x']This should then allow you to modify that last test to check for AttributeError on accessing x or y, instead of actually accessing them according to the old behavior.
Also, could you update the docstrings for .y and .x?
dopplershift
force-pushed
the
break-stuff
branch
from
67eeec7 to
1023f12
Compare
|
That make sense. I think I got it now. |
dopplershift
force-pushed
the
break-stuff
branch
from
1023f12 to
38d4c56
Compare
…ta#1112) This makes their behavior standard and eliminates the old behavior.
dopplershift
force-pushed
the
break-stuff
branch
from
38d4c56 to
a160534
Compare
This got dropped in the repo reorganization, so that only testing.py is included.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Remove everything we said was going away in 1.0:
test_xarray.pypasses and that makes me nervousfuture.pyinto their home (leavefuture.pyempty)This DOES NOT remove
dim_orderwhich is something else that needs to die in 1.0.Checklist