Fix pint 0.9 errors from units.wraps and iterable #1087
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #997, there were two main issues with pint 0.9 and MetPy:
@units.wraps
and single value Quantities being evaluated as iterable. This PR implements an alternate way of ensuring matching units (and stripping the units) for the interpolation functions that previously used@units.wraps
, as well as aniterable
function that checks against the magnitude of the argument.The two tests with matplotlib and scalar Quantities remain broken. I marked them as skipped for pint 0.9, but if a monkey patch of some kind based on the fix discussed in hgrecco/pint#751 is preferred, I can see what can be done.
Fixes #997.