Vendor internal imports from xarray.core in xarray.py #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
previously approved these changes
Jul 2, 2019
There was a problem hiding this comment.
Looks good, though its test coverage is a bit low since I don't think we were testing as much of it. Could you maybe add a test of our .loc using an Ellipsis?
Since everything is failing right now, I'm going to get #1078 in first.
dopplershift
added
Area: Xarray
|
I went ahead and added tests for all the portions of the utilities that were previously unused in the tests. Once #1078 is in, I'll rebase and hopefully this will be good to go! |
|
Needs a rebase anyway to address the conflict. |
|
Merging over skewT failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #1077, this PR vendors
either_dict_or_kwargs,expanded_indexer, andis_dict_like, which are used inmetpy/xarray.py, instead of using them from the internal API ofxarray.core(DatasetAccessoris handled in #1078).This is the first time I've tried vendoring code like this, so please do let me know if this is the right approach to take or if the code and/or license should be included elsewhere. Also, should I add tests of the vendored functions?