-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MegaMol Project Concept #978
Open
geringsj
wants to merge
14
commits into
master
Choose a base branch
from
project
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+300
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geringsj
commented
May 19, 2022
* Absolute path to project directory. If empty, no project path available. | ||
* This path is relative per guarantee of the frontend | ||
*/ | ||
std::filesystem::path project_directory; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might also be just a "prefix_path"
moritz-h
added a commit
that referenced
this pull request
Jun 2, 2022
Cherry pick graph clear fix from #978
Style check found formatting issues! Comment |
/format |
geringsj
force-pushed
the
project
branch
2 times, most recently
from
April 27, 2023 12:24
38de84d
to
f191efd
Compare
const members are complicated in C++, it seems
…gnatures using extensions + flags parameters to use FilePathStorage_t storage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses current lua script file path to determine a project directory, allowing FilePath Parameters to load files relative to that directory. The project directory is injected into file parameters of newly created graph modules.
TODO
param->ValueString()
)What happens when stacking project files?FilePathParams remember their respective project fileOptional Lua Callback Arguments (optional project name argument)Do we really want to clear() the graph?Only FilePathParam knows about project, re-routing all file loading through project dir too intrusivevislib::sys::File
andvislib::sys::File::Exists()
must dieScreenshots and other outputs go to project dir automatically?User configures screenshot outputTest Instructions
The implementation works for all code paths going though the Project Loader Service, e.g. Drag & Drop of files into the window and "Load Project" in the GUI.
For example, modify the
infovis.lua
example to access the example data set relative to the examples directory.