Profiling tests for Hagen #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
reinago
commented
Jul 29, 2021
•
reinago
commented
- added profiling capabilities to calls (activate via ENABLE_PROFILING in CMake)
- a bit of UX in configurator (nice graphs)
- fix for event transport across ContextToGL modules
- added CallCapabilities to enable asking Calls at runtime whether you should expect some kind of API at the other end
- cmake option - cpu timings in call
profile in modules instead?
- less dynamic querying - keep track of callback names
- query is probably best fetched before it is used again - TODO: still need double-buffering - lazy init of my_query_id internal class is so bad.
- still exlodes though.
- TODO: identifying calls by their pointer seems to be a bad idea
geringsj
reviewed
Sep 20, 2021
| #endif | ||
| res = this->callee->InCall(this->funcMap[func], *this); | ||
| #ifdef PROFILING | ||
| if (gl_started) { | ||
| CallProfiling::qm->Stop(this->callee->GetCoreInstance()->GetFrameID()); |
There was a problem hiding this comment.
If we want to get rid of the core instance one day we need some other way to access the FrameID.
geringsj
reviewed
Sep 20, 2021
geringsj
reviewed
Sep 21, 2021
geringsj
previously approved these changes
Sep 21, 2021
geringsj
reviewed
Sep 30, 2021
| @@ -0,0 +1,39 @@ | |||
| /* | |||
| * Screenshot_Service.hpp | |||
There was a problem hiding this comment.
Might want to change that
geringsj
previously approved these changes
Sep 30, 2021
geringsj
previously approved these changes
Sep 30, 2021
geringsj
previously approved these changes
Oct 1, 2021
geringsj
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.